Bug 110783

Summary: [texmap] Rename TextureMapperGL::ClipStack::init to reset
Product: WebKit Reporter: Bruno Abinader (history only) <bruno.abinader>
Component: Layout and RenderingAssignee: Bruno Abinader (history only) <bruno.abinader>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, igor.oliveira, luiz, noam, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Bruno Abinader (history only)
Reported 2013-02-25 12:37:01 PST
When debugging over TextureMapper::ClipStack, I've noticed that the ClipStack::init() function is used not only when begin painting, but also when clearing. I'm used to see init() functions being called inside ctor's to initialize member variables that were unable to be assigned on an initialization list, which is not the case, and also because reset() better reflects the behavior (clears the clip stack and assigns a value to the initial clip state).
Attachments
Patch (3.48 KB, patch)
2013-02-25 12:41 PST, Bruno Abinader (history only) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bruno Abinader (history only)
Comment 1 2013-02-25 12:41:10 PST
Created attachment 190106 [details] Patch Proposed patch
WebKit Review Bot
Comment 2 2013-02-25 20:06:31 PST
Comment on attachment 190106 [details] Patch Clearing flags on attachment: 190106 Committed r144003: <http://trac.webkit.org/changeset/144003>
WebKit Review Bot
Comment 3 2013-02-25 20:06:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.