Bug 110752

Summary: OpenCL implementation of FEImage SVG Filter.
Product: WebKit Reporter: Tamas Czene <tczene>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, d-r, fmalita, pdr, schenney, webkit.review.bot, zherczeg, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70099    
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch none

Tamas Czene
Reported 2013-02-25 05:46:23 PST
This implementation runs the software method and then it uploads the results to the OpenCL device.
Attachments
proposed patch (4.33 KB, patch)
2013-02-25 05:47 PST, Tamas Czene 		no flags
DetailsFormatted DiffDiff
proposed patch (4.36 KB, patch)
2013-02-25 05:48 PST, Tamas Czene 		no flags
DetailsFormatted DiffDiff
proposed patch (4.35 KB, patch)
2013-02-27 02:00 PST, Tamas Czene 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tamas Czene
Comment 1 2013-02-25 05:47:13 PST
Created attachment 190042 [details] proposed patch
Tamas Czene
Comment 2 2013-02-25 05:48:58 PST
Created attachment 190044 [details] proposed patch
Zoltan Herczeg
Comment 3 2013-02-27 01:41:12 PST
Comment on attachment 190044 [details] proposed patch Good patch, but the patch does not apply. Could you reupload the patch for chechking it again?
Tamas Czene
Comment 4 2013-02-27 02:00:19 PST
Created attachment 190472 [details] proposed patch
Stephen Chenney
Comment 5 2013-02-27 05:34:51 PST
Comment on attachment 190472 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=190472&action=review > Source/WebCore/svg/graphics/filters/SVGFEImage.h:43 > + virtual bool platformApplyOpenCL(); This has not been enforced on your patches to date, but WebKit standards say that all implementations of virtual methods must be explicitly marked OVERRIDE. Leave it for now but please follow up with a patch to fix all the overrides of platformApplyOpenCL.
Zoltan Herczeg
Comment 6 2013-02-28 03:42:45 PST
(In reply to comment #5) > (From update of attachment 190472 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190472&action=review > > > Source/WebCore/svg/graphics/filters/SVGFEImage.h:43 > > + virtual bool platformApplyOpenCL(); > > This has not been enforced on your patches to date, but WebKit standards say that all implementations of virtual methods must be explicitly marked OVERRIDE. Leave it for now but please follow up with a patch to fix all the overrides of platformApplyOpenCL. Good point.
Zoltan Herczeg
Comment 7 2013-02-28 03:43:40 PST
Comment on attachment 190472 [details] proposed patch r=me, but please make a follow-up patch for fixing all virtual methods.
WebKit Review Bot
Comment 8 2013-02-28 03:52:27 PST
Comment on attachment 190472 [details] proposed patch Clearing flags on attachment: 190472 Committed r144289: <http://trac.webkit.org/changeset/144289>
WebKit Review Bot
Comment 9 2013-02-28 03:52:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.