Bug 110736

Summary:

[BlackBerry] Upstream the datalist support UI

Product:

WebKit

Reporter:

Alberto Garcia <berto>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, esprehn+autocc, gyuyoung.kim, macpherson, menard, mifenton, ojan.autocc, rakuco, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cgarcia: review-, cgarcia: commit-queue-
Patch	none
Patch	none

Alberto Garcia

Reported 2013-02-25 01:47:23 PST

These are new suggestion box classes to support the datalist UI for textfields.

Attachments
Patch (28.51 KB, patch) 2013-02-25 01:50 PST, Alberto Garcia	cgarcia: review- cgarcia: commit-queue-	Details Formatted Diff Diff
Patch (28.47 KB, patch) 2013-02-25 09:03 PST, Alberto Garcia	no flags	Details Formatted Diff Diff
Patch (28.65 KB, patch) 2013-02-26 06:43 PST, Alberto Garcia	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alberto Garcia

Comment 1 2013-02-25 01:50:31 PST

Created attachment 190018 [details] Patch

WebKit Review Bot

Comment 2 2013-02-25 03:54:44 PST

Attachment 190018 [details] did not pass style-queue: Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1272: Should have a space between // and comment [whitespace/comments] [4] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:125: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:127: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:135: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:142: Omit int when using unsigned [runtime/unsigned] [1] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:143: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:144: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indenFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/themeBlackBerry.css', u'Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp', u'Source/WebCore/platform/blackberry/RenderThemeBlackBerry.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/PlatformBlackBerry.cmake', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxElement.cpp', u'Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxElement.h', u'Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp', u'Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.h', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.h', u'Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp']" exit_code: 1 t] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 26 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Carlos Garcia Campos

Comment 3 2013-02-25 08:05:54 PST

Comment on attachment 190018 [details] Patch We should fix coding style before upstreaming this.

Alberto Garcia

Comment 4 2013-02-25 09:03:40 PST

Created attachment 190070 [details] Patch Here's the updated patch

Alberto Garcia

Comment 5 2013-02-26 06:43:08 PST

Created attachment 190272 [details] Patch The author of the code was missing in the changelog

Mike Fenton

Comment 6 2013-02-26 06:46:31 PST

Comment on attachment 190272 [details] Patch Looks good to me!

Rob Buis

Comment 7 2013-02-26 07:08:58 PST

Comment on attachment 190272 [details] Patch LGTM.

WebKit Review Bot

Comment 8 2013-02-26 08:30:17 PST

Comment on attachment 190272 [details] Patch Clearing flags on attachment: 190272 Committed r144063: <http://trac.webkit.org/changeset/144063>

WebKit Review Bot

Comment 9 2013-02-26 08:30:23 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.