Bug 110726

Summary: [V8] Generate xxxAttrSetterCallback()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dgrogan, japhet, jsbell, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 110667    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2013-02-24 23:16:05 PST
This is one of steps to insert TRACE_EVENT_STATE() macros into DOM bindings. This patch introduces an indirection function for xxxAttrSetter(), like this: // For non-custom setters void xxxAttrSetterCallback(...) { xxxAttrSetter(...); } // For custom setters. void xxxAttrSetterCallback(...) { return xxxAttrSetterCustom(...); }
Attachments
Patch (88.41 KB, patch)
2013-02-24 23:49 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-02-24 23:49:10 PST
Created attachment 190003 [details] Patch
Kentaro Hara
Comment 2 2013-02-24 23:51:25 PST
Comment on attachment 190003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190003&action=review > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1199 > -sub GenerateNormalAttrSetter > +sub GenerateNormalAttrSetterCallback This diff is confusing, but basically I just factored out ${attrName}AttrSetterCallback() from GenerateNormalAttrSetter().
Kentaro Hara
Comment 3 2013-02-25 13:27:51 PST
Committed r143964: <http://trac.webkit.org/changeset/143964>
Note You need to log in before you can comment on or make changes to this bug.