Bug 110726 - [V8] Generate xxxAttrSetterCallback()
Summary: [V8] Generate xxxAttrSetterCallback()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 110667
  Show dependency treegraph
 
Reported: 2013-02-24 23:16 PST by Kentaro Hara
Modified: 2013-02-25 13:28 PST (History)
6 users (show)

See Also:


Attachments
Patch (88.41 KB, patch)
2013-02-24 23:49 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-24 23:16:05 PST
This is one of steps to insert TRACE_EVENT_STATE() macros into DOM bindings. This patch introduces an indirection function for xxxAttrSetter(), like this:

// For non-custom setters
void xxxAttrSetterCallback(...) {
  xxxAttrSetter(...);
}

// For custom setters.
void xxxAttrSetterCallback(...) {
  return xxxAttrSetterCustom(...);
}
Comment 1 Kentaro Hara 2013-02-24 23:49:10 PST
Created attachment 190003 [details]
Patch
Comment 2 Kentaro Hara 2013-02-24 23:51:25 PST
Comment on attachment 190003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190003&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1199
> -sub GenerateNormalAttrSetter
> +sub GenerateNormalAttrSetterCallback

This diff is confusing, but basically I just factored out ${attrName}AttrSetterCallback() from GenerateNormalAttrSetter().
Comment 3 Kentaro Hara 2013-02-25 13:27:51 PST
Committed r143964: <http://trac.webkit.org/changeset/143964>