| Summary: | Rollout r143556 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||
| Component: | CSS | Assignee: | Hajime Morrita <morrita> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | rniwa, tasak, tmpsantos, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 109909 | ||||||||
| Attachments: |
|
||||||||
|
Description
Hajime Morrita
2013-02-24 20:26:19 PST
Created attachment 189995 [details]
Patch for landing
Comment on attachment 189995 [details] Patch for landing Rejecting attachment 189995 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 189995, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16731891 Created attachment 189996 [details]
Patch for landing
Ryosuke pointed out the regression might be just a flake. I'd pend this until this is locally reproduced. Comment on attachment 189996 [details] Patch for landing https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22EFL%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Chromium%20Mac%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Chromium%20Win%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Mac%20Lion%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D&zoom=%5B1361317463017.8784%2C1361469076065.2822%5D Cosidering the trend is clear and the author will be unavailable for a while, it'd be better off roll it out then investigate one locally. Comment on attachment 189996 [details] Patch for landing Clearing flags on attachment: 189996 Committed r143885: <http://trac.webkit.org/changeset/143885> All reviewed patches have been landed. Closing bug. I noticed the same regression at the EFL perf bot. |