WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
110719
Rollout
r143556
https://bugs.webkit.org/show_bug.cgi?id=110719
Summary
Rollout r143556
Hajime Morrita
Reported
2013-02-24 20:26:19 PST
It regress perf. See
Bug 109909
.
Attachments
Patch for landing
(233.49 KB, patch)
2013-02-24 20:30 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Patch for landing
(233.53 KB, patch)
2013-02-24 20:36 PST
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Hajime Morrita
Comment 1
2013-02-24 20:30:49 PST
Created
attachment 189995
[details]
Patch for landing
WebKit Review Bot
Comment 2
2013-02-24 20:33:12 PST
Comment on
attachment 189995
[details]
Patch for landing Rejecting
attachment 189995
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 189995, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/16731891
Hajime Morrita
Comment 3
2013-02-24 20:36:29 PST
Created
attachment 189996
[details]
Patch for landing
Hajime Morrita
Comment 4
2013-02-24 21:01:04 PST
Ryosuke pointed out the regression might be just a flake. I'd pend this until this is locally reproduced.
Hajime Morrita
Comment 5
2013-02-24 22:06:43 PST
Comment on
attachment 189996
[details]
Patch for landing
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22EFL%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Chromium%20Mac%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Chromium%20Win%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Mac%20Lion%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D&zoom=%5B1361317463017.8784%2C1361469076065.2822%5D
Cosidering the trend is clear and the author will be unavailable for a while, it'd be better off roll it out then investigate one locally.
WebKit Review Bot
Comment 6
2013-02-24 23:02:05 PST
Comment on
attachment 189996
[details]
Patch for landing Clearing flags on attachment: 189996 Committed
r143885
: <
http://trac.webkit.org/changeset/143885
>
WebKit Review Bot
Comment 7
2013-02-24 23:02:10 PST
All reviewed patches have been landed. Closing bug.
Thiago Marcos P. Santos
Comment 8
2013-02-25 10:51:43 PST
I noticed the same regression at the EFL perf bot.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug