Bug 110716

Summary: [Mac] cleanup MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, feature-media-reviews, jer.noble, rniwa, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
buildbot: commit-queue-
Updated patch. none

Eric Carlson
Reported 2013-02-24 12:53:59 PST
Minor cleanup of the MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF classes
Attachments
Proposed patch (7.94 KB, patch)
2013-02-24 13:11 PST, Eric Carlson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Updated patch. (8.35 KB, patch)
2013-02-24 14:41 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-02-24 12:54:31 PST
<rdar://problem/13281692>
Eric Carlson
Comment 2 2013-02-24 13:11:28 PST
Created attachment 189987 [details] Proposed patch
Build Bot
Comment 3 2013-02-24 13:37:41 PST
Comment on attachment 189987 [details] Proposed patch Attachment 189987 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16730681
Build Bot
Comment 4 2013-02-24 14:01:15 PST
Comment on attachment 189987 [details] Proposed patch Attachment 189987 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16735666
Eric Carlson
Comment 5 2013-02-24 14:41:55 PST
Created attachment 189988 [details] Updated patch.
Alexey Proskuryakov
Comment 6 2013-02-24 16:13:58 PST
Comment on attachment 189988 [details] Updated patch. View in context: https://bugs.webkit.org/attachment.cgi?id=189988&action=review > Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:40 > + virtual ~AVFInbandTrackParent() { } Since there is already a matching .cpp file, it's better to to have the implementation there. Inlining destructors and constructors of polymorphic classes significantly and unnecessarily increases code bloat.
Eric Carlson
Comment 7 2013-02-24 20:00:23 PST
Committed http://trac.webkit.org/changeset/143884.
Note You need to log in before you can comment on or make changes to this bug.