Bug 110702

Summary: [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: New BugsAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, levin, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mrobinson: review+

Gustavo Noronha (kov)
Reported 2013-02-23 18:30:26 PST
[GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
Attachments
Patch (1.22 KB, patch)
2013-02-23 18:32 PST, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Patch (1.23 KB, patch)
2013-02-23 18:42 PST, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Patch (17.03 KB, patch)
2013-02-24 07:59 PST, Gustavo Noronha (kov) 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2013-02-23 18:32:27 PST
Created attachment 189948 [details] Patch
WebKit Review Bot
Comment 2 2013-02-23 18:34:46 PST
Attachment 189948 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/GtkVersioning.c']" exit_code: 1 Source/WebCore/platform/gtk/GtkVersioning.c:21: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gustavo Noronha (kov)
Comment 3 2013-02-23 18:42:25 PST
Created attachment 189949 [details] Patch
Gustavo Noronha (kov)
Comment 4 2013-02-24 07:59:43 PST
Created attachment 189977 [details] Patch
Martin Robinson
Comment 5 2013-02-24 09:17:36 PST
Comment on attachment 189977 [details] Patch Thanks for the fix. Minor nit is that usually there is no blank line after the first include.
Gustavo Noronha (kov)
Comment 6 2013-02-24 09:49:54 PST
Committed r143869: <http://trac.webkit.org/changeset/143869>
Gustavo Noronha (kov)
Comment 7 2013-02-24 10:10:50 PST
Nice sed trick I used to fix the nit: sed -i 'N;N;s/#include "autotoolsconfig.h"\n\n/#include "autotoolsconfig.h"\n/' *.c
Note You need to log in before you can comment on or make changes to this bug.