Bug 110665

Summary: ResourceRequestBase unnecessarily updates when nothing changes
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: msaboff, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2013-02-22 17:01:49 PST
ResourceRequestBase likes to set m_platformRequestUpdated to false even if nothing changed. Updating is a very expensive operation, and should be avoided as much as possible.
Attachments
proposed patch (3.92 KB, patch)
2013-02-22 17:05 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-02-22 17:05:31 PST
Created attachment 189869 [details] proposed patch
WebKit Review Bot
Comment 2 2013-02-23 23:31:01 PST
Comment on attachment 189869 [details] proposed patch Clearing flags on attachment: 189869 Committed r143861: <http://trac.webkit.org/changeset/143861>
WebKit Review Bot
Comment 3 2013-02-23 23:31:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.