Bug 110647

Summary: Threaded HTML parser should pass fast/parser/parser-yield-timing.html
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, ojan.autocc, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106127    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2013-02-22 14:45:54 PST
Thraeded HTML parser should pass fast/parser/parser-yield-timing.html
Attachments
Patch (5.14 KB, patch)
2013-02-22 14:49 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.19 KB, patch)
2013-02-23 09:49 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-02-22 14:49:11 PST
Created attachment 189838 [details] Patch
Eric Seidel (no email)
Comment 2 2013-02-22 14:54:11 PST
Comment on attachment 189838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189838&action=review > Source/WebCore/html/parser/HTMLDocumentParser.cpp:403 > + const double parserTimeLimit = 0.500; It seems like we should consider sharing this constant with the scheduler?
Tony Gentilcore
Comment 3 2013-02-22 15:01:57 PST
Comment on attachment 189838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189838&action=review lgtm This does seem like a likely cause of the good DCL numbers. > Source/WebCore/ChangeLog:3 > + Thraeded HTML parser should pass fast/parser/parser-yield-timing.html s/Thraeded/Threaded/
Adam Barth
Comment 4 2013-02-23 09:49:29 PST
Created attachment 189930 [details] Patch for landing
WebKit Review Bot
Comment 5 2013-02-23 10:39:37 PST
Comment on attachment 189930 [details] Patch for landing Clearing flags on attachment: 189930 Committed r143845: <http://trac.webkit.org/changeset/143845>
WebKit Review Bot
Comment 6 2013-02-23 10:39:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.