Bug 110647 - Threaded HTML parser should pass fast/parser/parser-yield-timing.html
Summary: Threaded HTML parser should pass fast/parser/parser-yield-timing.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-02-22 14:45 PST by Adam Barth
Modified: 2013-02-23 10:39 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.14 KB, patch)
2013-02-22 14:49 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (6.19 KB, patch)
2013-02-23 09:49 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-02-22 14:45:54 PST
Thraeded HTML parser should pass fast/parser/parser-yield-timing.html
Comment 1 Adam Barth 2013-02-22 14:49:11 PST
Created attachment 189838 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-02-22 14:54:11 PST
Comment on attachment 189838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189838&action=review

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:403
> +    const double parserTimeLimit = 0.500;

It seems like we should consider sharing this constant with the scheduler?
Comment 3 Tony Gentilcore 2013-02-22 15:01:57 PST
Comment on attachment 189838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189838&action=review

lgtm

This does seem like a likely cause of the good DCL numbers.

> Source/WebCore/ChangeLog:3
> +        Thraeded HTML parser should pass fast/parser/parser-yield-timing.html

s/Thraeded/Threaded/
Comment 4 Adam Barth 2013-02-23 09:49:29 PST
Created attachment 189930 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-02-23 10:39:37 PST
Comment on attachment 189930 [details]
Patch for landing

Clearing flags on attachment: 189930

Committed r143845: <http://trac.webkit.org/changeset/143845>
Comment 6 WebKit Review Bot 2013-02-23 10:39:40 PST
All reviewed patches have been landed.  Closing bug.