Bug 110646

Summary: Document::styleRecalc() and FrameView::layout() should be traced
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: Layout and RenderingAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, nduca, ojan, rego+ews, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing
none
patch for landing none

Kentaro Hara
Reported 2013-02-22 14:18:50 PST
Document::styleRecalc() and FrameView::layout() are key factors for web page rendering performance. We should add TRACE_EVENT() macros to these functions.
Attachments
Patch (2.58 KB, patch)
2013-02-22 14:19 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (2.52 KB, patch)
2013-02-22 14:41 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (2.59 KB, patch)
2013-02-22 15:03 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-02-22 14:19:50 PST
Created attachment 189827 [details] Patch
Kentaro Hara
Comment 2 2013-02-22 14:24:41 PST
I found that style recalculation and layout have not been traced... With the patch, we can observe style recalculations and layouts inside v8.run and v8.callFunction. (That being said, style recalculations and layouts explain a small part of v8.run and v8.callFunction when we open a Google Docs.)
Early Warning System Bot
Comment 3 2013-02-22 14:30:42 PST
Comment on attachment 189827 [details] Patch Attachment 189827 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16723091
Ojan Vafai
Comment 4 2013-02-22 14:33:43 PST
Comment on attachment 189827 [details] Patch Makes sense.
Early Warning System Bot
Comment 5 2013-02-22 14:37:05 PST
Comment on attachment 189827 [details] Patch Attachment 189827 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16718223
Kentaro Hara
Comment 6 2013-02-22 14:41:06 PST
Created attachment 189834 [details] patch for landing
WebKit Review Bot
Comment 7 2013-02-22 15:02:43 PST
Comment on attachment 189834 [details] patch for landing Clearing flags on attachment: 189834 Committed r143805: <http://trac.webkit.org/changeset/143805>
WebKit Review Bot
Comment 8 2013-02-22 15:02:47 PST
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 9 2013-02-22 15:03:30 PST
Reopening to attach new patch.
Kentaro Hara
Comment 10 2013-02-22 15:03:32 PST
Created attachment 189842 [details] patch for landing
Note You need to log in before you can comment on or make changes to this bug.