Bug 110643 – Teach the html5lib tests how to test the threaded HTML parser

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Teach the html5lib tests how to test the threaded HTML parser

[Eric Seidel (no email)]

Created attachment 189823 [details]
Patch

[WebKit Review Bot]

Comment on attachment 189823 [details]
Patch

Rejecting attachment 189823 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189823, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:

fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2

Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Full output: http://queues.webkit.org/results/16708300

[WebKit Review Bot]

Comment on attachment 189823 [details]
Patch

Clearing flags on attachment: 189823

Committed r143804: <http://trac.webkit.org/changeset/143804>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

This patch appears to have broken 3 html5lib tests on Mac WK1:
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/7172

[Eric Seidel (no email)]

I'm sure it didn't break anything. :)  I suspect I just rebaselined from Chromium and previously chromium was using its own baselines for that test.  Just needs gardening.

[Ryosuke Niwa]

(In reply to comment #6)
> I'm sure it didn't break anything. :)  I suspect I just rebaselined from Chromium and previously chromium was using its own baselines for that test.  Just needs gardening.

Oh, it seems like you just didn't rebaseline those tests. Maybe they're disabled on Chromium?

[Eric Seidel (no email)]

That's also possible?  Not sure.   I can't remember if we have different results for v8 for some of these tests. :(

[Ryosuke Niwa]

(In reply to comment #8)
> That's also possible?  Not sure.   I can't remember if we have different results for v8 for some of these tests. :(

You didn't baseline 1, 7, & 18 in http://trac.webkit.org/changeset/143804, and that's exactly the set of tests failing on bots. I'm rebaselining them now.

[Eric Seidel (no email)]

Thank you very much.

[Ryosuke Niwa]

(In reply to comment #9)
> (In reply to comment #8)
> > That's also possible?  Not sure.   I can't remember if we have different results for v8 for some of these tests. :(
> 
> You didn't baseline 1, 7, & 18 in http://trac.webkit.org/changeset/143804, and that's exactly the set of tests failing on bots. I'm rebaselining them now.

Done that in http://trac.webkit.org/changeset/143823.

[Adam Barth]

I bet that means they're skipped in Chromium.  We should double-check them in the threaded parser.

[Ryosuke Niwa]

(In reply to comment #12)
> I bet that means they're skipped in Chromium.  We should double-check them in the threaded parser.

I misspoke. They have chromium-specific results due to parser error being different on JSC/V8 :(

[WebKit Review Bot]

Re-opened since this is blocked by bug 110729

[Ryosuke Niwa]

Closing the bug again since the rollout bugs have been closed as invalid.