| Summary: | Teach the html5lib tests how to test the threaded HTML parser | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, rniwa, tonyg, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 110729, 110730 | ||||||
| Bug Blocks: | 110642, 106127 | ||||||
| Attachments: |
|
||||||
|
Description
Eric Seidel (no email)
2013-02-22 14:10:11 PST
Created attachment 189823 [details]
Patch
Comment on attachment 189823 [details] Patch Rejecting attachment 189823 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189823, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://queues.webkit.org/results/16708300 Comment on attachment 189823 [details] Patch Clearing flags on attachment: 189823 Committed r143804: <http://trac.webkit.org/changeset/143804> All reviewed patches have been landed. Closing bug. This patch appears to have broken 3 html5lib tests on Mac WK1: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/7172 I'm sure it didn't break anything. :) I suspect I just rebaselined from Chromium and previously chromium was using its own baselines for that test. Just needs gardening. (In reply to comment #6) > I'm sure it didn't break anything. :) I suspect I just rebaselined from Chromium and previously chromium was using its own baselines for that test. Just needs gardening. Oh, it seems like you just didn't rebaseline those tests. Maybe they're disabled on Chromium? That's also possible? Not sure. I can't remember if we have different results for v8 for some of these tests. :( (In reply to comment #8) > That's also possible? Not sure. I can't remember if we have different results for v8 for some of these tests. :( You didn't baseline 1, 7, & 18 in http://trac.webkit.org/changeset/143804, and that's exactly the set of tests failing on bots. I'm rebaselining them now. Thank you very much. (In reply to comment #9) > (In reply to comment #8) > > That's also possible? Not sure. I can't remember if we have different results for v8 for some of these tests. :( > > You didn't baseline 1, 7, & 18 in http://trac.webkit.org/changeset/143804, and that's exactly the set of tests failing on bots. I'm rebaselining them now. Done that in http://trac.webkit.org/changeset/143823. I bet that means they're skipped in Chromium. We should double-check them in the threaded parser. (In reply to comment #12) > I bet that means they're skipped in Chromium. We should double-check them in the threaded parser. I misspoke. They have chromium-specific results due to parser error being different on JSC/V8 :( Re-opened since this is blocked by bug 110729 Closing the bug again since the rollout bugs have been closed as invalid. |