Bug 110640 – [chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient

• Component: New Bugs
• Status: RESOLVED FIXED

[James Robinson]

[chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient

[James Robinson]

Created attachment 189820 [details]
Patch

[James Robinson]

Comment on attachment 189820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189820&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:-4022
> -    IntRect damagedRect(0, 0, m_size.width, m_size.height);
> -    if (!m_isAcceleratedCompositingActive && !m_suppressInvalidations)
> -        m_client->didInvalidateRect(damagedRect);

This is dead code - m_suppressInvalidations will always be true here since it's set at the top of the function.  I'm not sure how we got into this state but everything seems to be working fine.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adrienne Walker]

Comment on attachment 189820 [details]
Patch

R=me.

[WebKit Review Bot]

Comment on attachment 189820 [details]
Patch

Clearing flags on attachment: 189820

Committed r143985: <http://trac.webkit.org/changeset/143985>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.