Bug 110631

Summary: ScrollingStateTree::rootStateNode() should be null-checked since it can be null
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cmarcelo, hugo, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Beth Dakin
Reported 2013-02-22 12:48:46 PST
ScrollingStateTree::rootStateNode() can be null when you are navigating between pages. There are two places in the code that don't null-check it, and I believe that those spots are responsible for some non-reproducible crashes that we have reports of. I believe this patch will fix https://bugs.webkit.org/show_bug.cgi?id=110509 which corresponds to <rdar://problem/12519348> and also <rdar://problem/13233090>. The offsets in those crashes do appear to be attempts at accessing setShouldUpdateScrollLayerPositionOnMainThread() and children() respectively on a null ScrollingStateNode.
Attachments
Patch (2.04 KB, patch)
2013-02-22 12:51 PST, Beth Dakin 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2013-02-22 12:51:15 PST
Created attachment 189808 [details] Patch
Beth Dakin
Comment 2 2013-02-22 13:40:06 PST
Thanks! http://trac.webkit.org/changeset/143785
Beth Dakin
Comment 3 2013-02-22 13:40:42 PST
*** Bug 110509 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.