Bug 110617

Summary: [BlackBerry] Accept key events even when composing region is active.
Product: WebKit Reporter: Mike Fenton <mifenton>
Component: WebKit BlackBerryAssignee: Mike Fenton <mifenton>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Updated patch with space fixed.
none
Fix missing header. none

Description Mike Fenton 2013-02-22 09:49:29 PST 
SSIA.
Comment 1 Mike Fenton 2013-02-22 09:56:58 PST 
Created attachment 189786 [details]
Patch
Comment 2 Rob Buis 2013-02-22 10:25:23 PST 
Comment on attachment 189786 [details]
Patch

Ok.
Comment 3 WebKit Review Bot 2013-02-22 12:00:58 PST 
Comment on attachment 189786 [details]
Patch

Clearing flags on attachment: 189786

Committed r143767: <http://trac.webkit.org/changeset/143767>
Comment 4 WebKit Review Bot 2013-02-22 12:01:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Mike Fenton 2013-02-26 08:32:36 PST 
Previous patch caused regression when a raw modifier key came through.  Updating to be more strict.
Comment 6 Mike Fenton 2013-02-26 08:36:40 PST 
Created attachment 190294 [details]
Patch
Comment 7 Yong Li 2013-02-26 11:55:53 PST 
Comment on attachment 190294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190294&action=review

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1669
>  }
> +bool InputHandler::isNavigationKey(unsigned character) const

need a space?
Comment 8 Mike Fenton 2013-02-27 06:57:33 PST 
Created attachment 190512 [details]
Updated patch with space fixed.
Comment 9 Mike Fenton 2013-02-27 07:05:09 PST 
Created attachment 190514 [details]
Fix missing header.
Comment 10 Rob Buis 2013-02-27 07:06:19 PST 
Comment on attachment 190514 [details]
Fix missing header.

LGTM.
Comment 11 WebKit Review Bot 2013-02-27 07:30:09 PST 
Comment on attachment 190514 [details]
Fix missing header.

Rejecting attachment 190514 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190514, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:

fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2

Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Full output: http://webkit-commit-queue.appspot.com/results/16831294
Comment 12 WebKit Review Bot 2013-02-27 08:28:01 PST 
Comment on attachment 190514 [details]
Fix missing header.

Clearing flags on attachment: 190514

Committed r144193: <http://trac.webkit.org/changeset/144193>
Comment 13 WebKit Review Bot 2013-02-27 08:28:05 PST 
All reviewed patches have been landed.  Closing bug.