Bug 110608

Summary: [EFL][WK2] REGRESSION(r143582): API test EWK2UnitTestBase.ewk_view_contents_size_changed failing
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, gyuyoung.kim, kenneth, kling, lucas.de.marchi, mikhail.pozdnyakov, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111543    
Attachments:
Description Flags
Patch
kenneth: review+
Patch for landing none

Sudarsana Nagineni (babu)
Reported 2013-02-22 07:48:35 PST
API test EWK2UnitTestBase.ewk_view_contents_size_changed started failing after r143582. http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/9706/steps/API%20tests/logs/stdio
Attachments
Patch (2.47 KB, patch)
2013-02-24 11:59 PST, Sudarsana Nagineni (babu) 		kenneth: review+
DetailsFormatted DiffDiff
Patch for landing (2.51 KB, patch)
2013-03-06 13:16 PST, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2013-02-24 11:59:45 PST
Created attachment 189984 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2013-02-24 14:02:14 PST
Comment on attachment 189984 [details] Patch This is probably fine, but let's see what Mikhail thinks
Mikhail Pozdnyakov
Comment 3 2013-02-24 23:33:56 PST
Comment on attachment 189984 [details] Patch Looks good, thanks Babu
Benjamin Poulain
Comment 4 2013-03-06 10:27:54 PST
Okay for WebKit2.
Kenneth Rohde Christiansen
Comment 5 2013-03-06 10:49:08 PST
Comment on attachment 189984 [details] Patch r=me as signed off by ben
Sudarsana Nagineni (babu)
Comment 6 2013-03-06 13:15:40 PST
Thanks for review!
Sudarsana Nagineni (babu)
Comment 7 2013-03-06 13:16:57 PST
Created attachment 191817 [details] Patch for landing Rebased.
WebKit Review Bot
Comment 8 2013-03-06 13:37:27 PST
Comment on attachment 191817 [details] Patch for landing Clearing flags on attachment: 191817 Committed r144975: <http://trac.webkit.org/changeset/144975>
WebKit Review Bot
Comment 9 2013-03-06 13:37:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.