Bug 110608 - [EFL][WK2] REGRESSION(r143582): API test EWK2UnitTestBase.ewk_view_contents_size_changed failing
Summary: [EFL][WK2] REGRESSION(r143582): API test EWK2UnitTestBase.ewk_view_contents_s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks: 111543
  Show dependency tree / graph
 
Reported: 2013-02-22 07:48 PST by Sudarsana Nagineni (babu)
Modified: 2013-03-06 13:37 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2013-02-24 11:59 PST, Sudarsana Nagineni (babu) 		kenneth: review+
Details | Formatted Diff | Diff
Patch for landing (2.51 KB, patch)
2013-03-06 13:16 PST, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2013-02-22 07:48:35 PST 
API test EWK2UnitTestBase.ewk_view_contents_size_changed started failing after r143582.

http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/9706/steps/API%20tests/logs/stdio
Comment 1 Sudarsana Nagineni (babu) 2013-02-24 11:59:45 PST 
Created attachment 189984 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2013-02-24 14:02:14 PST 
Comment on attachment 189984 [details]
Patch

This is probably fine, but let's see what Mikhail thinks
Comment 3 Mikhail Pozdnyakov 2013-02-24 23:33:56 PST 
Comment on attachment 189984 [details]
Patch

Looks good, thanks Babu
Comment 4 Benjamin Poulain 2013-03-06 10:27:54 PST 
Okay for WebKit2.
Comment 5 Kenneth Rohde Christiansen 2013-03-06 10:49:08 PST 
Comment on attachment 189984 [details]
Patch

r=me as signed off by ben
Comment 6 Sudarsana Nagineni (babu) 2013-03-06 13:15:40 PST 
Thanks for review!
Comment 7 Sudarsana Nagineni (babu) 2013-03-06 13:16:57 PST 
Created attachment 191817 [details]
Patch for landing

Rebased.
Comment 8 WebKit Review Bot 2013-03-06 13:37:27 PST 
Comment on attachment 191817 [details]
Patch for landing

Clearing flags on attachment: 191817

Committed r144975: <http://trac.webkit.org/changeset/144975>
Comment 9 WebKit Review Bot 2013-03-06 13:37:31 PST 
All reviewed patches have been landed.  Closing bug.