Bug 110605

Summary: [Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110615    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2013-02-22 06:48:07 PST
[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
Attachments
Patch (4.01 KB, patch)
2013-02-22 06:49 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (4.16 KB, patch)
2013-02-23 08:51 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2013-02-22 06:49:00 PST
Created attachment 189767 [details] Patch
WebKit Review Bot
Comment 2 2013-02-22 07:51:33 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kentaro Hara
Comment 3 2013-02-22 08:37:00 PST
Comment on attachment 189767 [details] Patch pilgrim: oops, would you set r? again to wait for API reviewers?
WebKit Review Bot
Comment 4 2013-02-22 08:43:09 PST
Comment on attachment 189767 [details] Patch Clearing flags on attachment: 189767 Committed r143734: <http://trac.webkit.org/changeset/143734>
WebKit Review Bot
Comment 5 2013-02-22 08:43:13 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2013-02-22 09:04:41 PST
Re-opened since this is blocked by bug 110615
Mark Pilgrim (Google)
Comment 7 2013-02-23 08:51:37 PST
Created attachment 189927 [details] Patch
Mark Pilgrim (Google)
Comment 8 2013-02-23 08:54:21 PST
Comment on attachment 189927 [details] Patch This patch fixes the downstream compilation issue by explicitly including Platform.h so other files that include WebKit.h know that WebKitPlatformSupport inherits from Platform class.
WebKit Review Bot
Comment 9 2013-02-23 11:58:53 PST
Comment on attachment 189927 [details] Patch Clearing flags on attachment: 189927 Committed r143846: <http://trac.webkit.org/changeset/143846>
WebKit Review Bot
Comment 10 2013-02-23 11:58:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.