Bug 110599

Summary: Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, benjamin, cmarcelo, esprehn+autocc, japhet, keishi, loislo, macpherson, menard, ojan.autocc, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Ilya Tikhonovsky
Reported 2013-02-22 05:39:12 PST
It costs us additional allocation for StringImpl. It forced us to have separate header for MemoryObjectInfo and gives unnecessary complexity of the code.
Attachments
Patch (16.12 KB, patch)
2013-02-23 04:30 PST, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2013-02-23 04:30:02 PST
Created attachment 189923 [details] Patch
Yury Semikhatsky
Comment 2 2013-02-25 05:13:12 PST
Comment on attachment 189923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189923&action=review > Source/WebCore/inspector/HeapGraphSerializer.cpp:217 > + length = length < 256 ? length : 256; if (length > 256) length = 256;
Ilya Tikhonovsky
Comment 3 2013-02-25 05:39:33 PST
Committed r143913: <http://trac.webkit.org/changeset/143913>
Note You need to log in before you can comment on or make changes to this bug.