Bug 110589

Summary:

Add a scrollbar class for the new calendar picker

Product:

WebKit

Reporter:

Keishi Hattori <keishi>

Component:

Forms

Assignee:

Keishi Hattori <keishi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

109439

Attachments:

Description	Flags
Patch	none
Patch	none

Description Keishi Hattori 2013-02-22 04:43:40 PST

Add a scrollbar class for the new calendar picker

Comment 1 Keishi Hattori 2013-02-25 00:21:31 PST

Created attachment 190008 [details]
Patch

Comment 2 Kent Tamura 2013-02-25 01:42:56 PST

Comment on attachment 190008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190008&action=review

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1378
> +    this.knob = createElement("div", ScrubbyScrollBar.ClassNameScrubbyScrollKnob);

nit: I think we usually call it "thumb" in WebKit, not "knob".

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1522
> +    if (this._knobPosition < 0)
> +        scrollAmount = -scrollAmount;
> +        scrollAmount = -scrollAmount;

duplicated lines

Comment 3 Keishi Hattori 2013-02-25 03:08:59 PST

Created attachment 190025 [details]
Patch

Comment 4 WebKit Review Bot 2013-02-25 05:21:59 PST

Comment on attachment 190025 [details]
Patch

Clearing flags on attachment: 190025

Committed r143911: <http://trac.webkit.org/changeset/143911>

Comment 5 WebKit Review Bot 2013-02-25 05:22:02 PST

All reviewed patches have been landed.  Closing bug.