Summary: | Add a scrollbar class for the new calendar picker | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keishi Hattori <keishi> | ||||||
Component: | Forms | Assignee: | Keishi Hattori <keishi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 109439 | ||||||||
Attachments: |
|
Description
Keishi Hattori
2013-02-22 04:43:40 PST
Created attachment 190008 [details]
Patch
Comment on attachment 190008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190008&action=review > Source/WebCore/Resources/pagepopups/calendarPicker.js:1378 > + this.knob = createElement("div", ScrubbyScrollBar.ClassNameScrubbyScrollKnob); nit: I think we usually call it "thumb" in WebKit, not "knob". > Source/WebCore/Resources/pagepopups/calendarPicker.js:1522 > + if (this._knobPosition < 0) > + scrollAmount = -scrollAmount; > + scrollAmount = -scrollAmount; duplicated lines Created attachment 190025 [details]
Patch
Comment on attachment 190025 [details] Patch Clearing flags on attachment: 190025 Committed r143911: <http://trac.webkit.org/changeset/143911> All reviewed patches have been landed. Closing bug. |