Bug 110481

Summary: [Chromium] Disable registerProtocolHandler on Android
Product: WebKit Reporter: Anton Vayvod <avayvod>
Component: New BugsAssignee: Anton Vayvod <avayvod>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, peter, syoichi, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Anton Vayvod
Reported 2013-02-21 08:51:17 PST
[Chromium] Disable registerProtocolHandler on Android
Attachments
Patch (2.95 KB, patch)
2013-02-21 08:55 PST, Anton Vayvod 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2013-02-21 09:10 PST, Anton Vayvod 		no flags
DetailsFormatted DiffDiff
Patch (3.03 KB, patch)
2013-02-25 04:06 PST, Anton Vayvod 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Anton Vayvod
Comment 1 2013-02-21 08:55:40 PST
Created attachment 189540 [details] Patch
Anton Vayvod
Comment 2 2013-02-21 08:57:27 PST
Julien, since you reviewed the first attempt, could you take a look, please?
Anton Vayvod
Comment 3 2013-02-21 09:10:33 PST
Created attachment 189545 [details] Patch
Julien Chaffraix
Comment 4 2013-02-22 12:46:48 PST
Comment on attachment 189545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189545&action=review r=me, but the ChangeLog should be amended before landing. > Source/WebKit/chromium/ChangeLog:12 > + You should mention the *why* which the original change properly explained: this is done because Android doesn't wire the implementation and you don't want to break feature detection. crbug.com/156386 should also be mentioned as it properly highlight the challenges of implementing it in Android.
Anton Vayvod
Comment 5 2013-02-25 04:06:39 PST
Created attachment 190029 [details] Patch
Peter Beverloo
Comment 6 2013-02-25 04:19:54 PST
Comment on attachment 190029 [details] Patch Thank you for the explanation! SGTM.
WebKit Review Bot
Comment 7 2013-02-25 06:08:36 PST
Comment on attachment 190029 [details] Patch Clearing flags on attachment: 190029 Committed r143917: <http://trac.webkit.org/changeset/143917>
WebKit Review Bot
Comment 8 2013-02-25 06:08:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.