Summary: | [Chromium] Disable registerProtocolHandler on Android | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anton Vayvod <avayvod> | ||||||||
Component: | New Bugs | Assignee: | Anton Vayvod <avayvod> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | jchaffraix, peter, syoichi, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | WebExposed | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Anton Vayvod
2013-02-21 08:51:17 PST
Created attachment 189540 [details]
Patch
Julien, since you reviewed the first attempt, could you take a look, please? Created attachment 189545 [details]
Patch
Comment on attachment 189545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189545&action=review r=me, but the ChangeLog should be amended before landing. > Source/WebKit/chromium/ChangeLog:12 > + You should mention the *why* which the original change properly explained: this is done because Android doesn't wire the implementation and you don't want to break feature detection. crbug.com/156386 should also be mentioned as it properly highlight the challenges of implementing it in Android. Created attachment 190029 [details]
Patch
Comment on attachment 190029 [details]
Patch
Thank you for the explanation! SGTM.
Comment on attachment 190029 [details] Patch Clearing flags on attachment: 190029 Committed r143917: <http://trac.webkit.org/changeset/143917> All reviewed patches have been landed. Closing bug. |