Bug 110477

Summary: [New Multicolumn] Remove unneeded layout method in RenderMultiColumnFlowThread
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Dave Hyatt
Reported 2013-02-21 08:29:02 PST
I forgot that both the sets and the flow thread lay out before the containing RenderMultiColumnBlock has finished. That means it hasn't computed its overflow yet. Therefore there is no need to force it to compute its overflow from inside RenderMultiColumnFlowThread::layout, because the minute RenderMultiColumnFlowThread finishes its layout, the block will compute its overflow anyway.
Attachments
Patch (2.62 KB, patch)
2013-02-21 08:30 PST, Dave Hyatt 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2013-02-21 08:30:16 PST
Created attachment 189537 [details] Patch
Dave Hyatt
Comment 2 2013-02-21 08:34:54 PST
Fixed in r143606.
Note You need to log in before you can comment on or make changes to this bug.