Bug 110470 – [GTK][AC] Animating layer disappears while running with clutter backend

• Component: WebKitGTK
• Status: RESOLVED FIXED

[ChangSeok Oh]

'Toss' & 'fade through' demo in http://www.apple.com/html5/showcase/transitions/ don't run well.
Nothing is shown while animation.

[ChangSeok Oh]

Created attachment 189790 [details]
Patch

[ChangSeok Oh]

This patch applied to webkit-clutter as well.
http://cgit.collabora.com/git/webkit-clutter.git/commit/?h=wip/changseok/unreviewed&id=fcd8e7cd47f2a0b68110fd709ccf9919cb84c11c

[Gustavo Noronha (kov)]

Comment on attachment 189790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189790&action=review

I could not reproduce this problem in webkit-clutter. I guess it might be a bad interaction with clutter-gtk. The change makes sense anyway. Please merge this change to webkit-clutter master as well! cq- because of the requested changes.

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:656
> +        GraphicsLayerClutter* curChild = static_cast<GraphicsLayerClutter*>(childLayers[i]);

Let's take the opportunity to fix the naming here, curChild -> currentChild

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:658
> +        g_assert(GRAPHICS_LAYER_IS_ACTOR(childLayer));

Make this an ASSERT() instead.

[ChangSeok Oh]

Created attachment 195508 [details]
Patch

[ChangSeok Oh]

Created attachment 195514 [details]
Patch

[ChangSeok Oh]

Comment on attachment 189790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189790&action=review

Thank you for the review!

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:656
>> +        GraphicsLayerClutter* curChild = static_cast<GraphicsLayerClutter*>(childLayers[i]);
> 
> Let's take the opportunity to fix the naming here, curChild -> currentChild

Done.

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:658
>> +        g_assert(GRAPHICS_LAYER_IS_ACTOR(childLayer));
> 
> Make this an ASSERT() instead.

Done.

[ChangSeok Oh]

(In reply to comment #3)
> (From update of attachment 189790 [details])
> Please merge this change to webkit-clutter master as well! cq- because of the requested changes.
Yeap. I'll do immediately after landing this patch!

[WebKit Review Bot]

Comment on attachment 195514 [details]
Patch

Clearing flags on attachment: 195514

Committed r147121: <http://trac.webkit.org/changeset/147121>