Bug 110459

Summary: [GTK] Control+Shift+Up/Down selection works backwards
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+

Claudio Saavedra
Reported 2013-02-21 05:12:14 PST
[GTK] Control+Shift+Up/Down selection works backwards
Attachments
Patch (2.15 KB, patch)
2013-02-21 05:23 PST, Claudio Saavedra 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2013-02-21 05:23:20 PST
Created attachment 189513 [details] Patch
WebKit Review Bot
Comment 2 2013-02-21 05:31:49 PST
Attachment 189513 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/KeyBindingTranslator.cpp']" exit_code: 1 Source/WebCore/platform/gtk/KeyBindingTranslator.cpp:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 3 2013-02-21 13:03:38 PST
Comment on attachment 189513 [details] Patch Okay. It would be nice to see a test, but this looks pretty straight-forward.
Claudio Saavedra
Comment 4 2013-02-22 00:43:00 PST
Committed r143696: <http://trac.webkit.org/changeset/143696>
Note You need to log in before you can comment on or make changes to this bug.