Bug 110459 - [GTK] Control+Shift+Up/Down selection works backwards
Summary: [GTK] Control+Shift+Up/Down selection works backwards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-21 05:12 PST by Claudio Saavedra
Modified: 2013-02-22 00:43 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.15 KB, patch)
2013-02-21 05:23 PST, Claudio Saavedra 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2013-02-21 05:12:14 PST 
[GTK] Control+Shift+Up/Down selection works backwards
Comment 1 Claudio Saavedra 2013-02-21 05:23:20 PST 
Created attachment 189513 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-21 05:31:49 PST 
Attachment 189513 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/KeyBindingTranslator.cpp']" exit_code: 1
Source/WebCore/platform/gtk/KeyBindingTranslator.cpp:138:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Martin Robinson 2013-02-21 13:03:38 PST 
Comment on attachment 189513 [details]
Patch

Okay. It would be nice to see a test, but this looks pretty straight-forward.
Comment 4 Claudio Saavedra 2013-02-22 00:43:00 PST 
Committed r143696: <http://trac.webkit.org/changeset/143696>