Bug 110459 - [GTK] Control+Shift+Up/Down selection works backwards
: [GTK] Control+Shift+Up/Down selection works backwards
Status: RESOLVED FIXED
: WebKit
WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2013-02-21 05:12 PST by
Modified: 2013-02-22 00:43 PST (History)


Attachments
Patch (2.15 KB, patch)
2013-02-21 05:23 PST, Claudio Saavedra
mrobinson: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2013-02-21 05:12:14 PST
[GTK] Control+Shift+Up/Down selection works backwards
------- Comment #1 From 2013-02-21 05:23:20 PST -------
Created an attachment (id=189513) [details]
Patch
------- Comment #2 From 2013-02-21 05:31:49 PST -------
Attachment 189513 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/KeyBindingTranslator.cpp']" exit_code: 1
Source/WebCore/platform/gtk/KeyBindingTranslator.cpp:138:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2013-02-21 13:03:38 PST -------
(From update of attachment 189513 [details])
Okay. It would be nice to see a test, but this looks pretty straight-forward.
------- Comment #4 From 2013-02-22 00:43:00 PST -------
Committed r143696: <http://trac.webkit.org/changeset/143696>