Summary: | CMake should not require build target | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Salisbury <mark.salisbury> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | laszlo.gombos, mark.salisbury, paroga | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Mark Salisbury
2013-02-20 17:26:06 PST
Created attachment 189431 [details]
Proposed fix
Am I alone in seeing this issue as a problem? Maybe I wasn't clear in describing the issue? Comment on attachment 189431 [details] Proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=189431&action=review > CMakeLists.txt:12 > -string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE) > +if (CMAKE_BUILD_TYPE) > + string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE) > +endif () IMHO we should only remove the TOLOWER and replace "debug" with "Debug" in the other CMake files Redolved with https://trac.webkit.org/changeset/147992 *** This bug has been marked as a duplicate of bug 114243 *** Comment on attachment 189431 [details] Proposed fix Cleared review? from attachment 189431 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). |