Bug 110414 – CMake should not require build target

• Component: Platform
• Status: RESOLVED DUPLICATE

[Mark Salisbury]

A bug was introduced recently (IMO) that requires a build target (Debug, Release, RelWithDebInfo, MinSizeRelease) to be specified when invoking CMake.  If you don't specify a build target, you get an error from the top level CMakeLists.txt file on line 10 because it attempts to convert the build type "tolower".

When I run CMake I have it to generate Visual Studio project files, then I open WebKit.sln and build from inside the VS IDE.

The change I'd like to see guarded was introduced in http://trac.webkit.org/changeset/140990.

[Mark Salisbury]

Created attachment 189431 [details]
Proposed fix

[Mark Salisbury]

Am I alone in seeing this issue as a problem?  Maybe I wasn't clear in describing the issue?

[Patrick R. Gansterer]

Comment on attachment 189431 [details]
Proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=189431&action=review

> CMakeLists.txt:12
> -string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE)
> +if (CMAKE_BUILD_TYPE)
> +    string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE)
> +endif ()

IMHO we should only remove the TOLOWER and replace "debug" with "Debug" in the other CMake files

[Patrick R. Gansterer]

Redolved with https://trac.webkit.org/changeset/147992

*** This bug has been marked as a duplicate of bug 114243 ***

[Csaba Osztrogonác]

Comment on attachment 189431 [details]
Proposed fix

Cleared review? from attachment 189431 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).