Bug 110410

Summary: Specify plug-in process / service entitlements via the Xcode configuration
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebKit2Assignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 ap: review+

Description Mark Rowe (bdash) 2013-02-20 16:52:57 PST
This is the modern mechanism for applying entitlements to production builds, and it simplifies the maintenance of entitlements going forward.
Comment 1 Mark Rowe (bdash) 2013-02-20 16:53:16 PST
Created attachment 189418 [details]
Patch v1
Comment 2 WebKit Review Bot 2013-02-20 16:57:29 PST
Attachment 189418 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/Base.xcconfig', u'Source/WebKit2/Configurations/PluginProcess.xcconfig', u'Source/WebKit2/Configurations/PluginService.32.xcconfig', u'Source/WebKit2/Configurations/PluginService.64.xcconfig', u'Source/WebKit2/Configurations/PluginService.Development.xcconfig', u'Source/WebKit2/Configurations/PluginService.entitlements', u'Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements', u'Source/WebKit2/PluginProcess/mac/add-entitlements.sh', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2013-02-20 17:31:01 PST
Landed in r143544.