Bug 110409

Summary: Clean up PluginService info plists
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebKit2Assignee: Mark Rowe (bdash) <mrowe>
Severity: Normal CC: sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch v1
Patch v2 mitz: review+

Description Mark Rowe (bdash) 2013-02-20 16:50:28 PST
The 32- and 64-bit plists are virtually identical. They can share a single plist and rely on build setting expansion to fill in the differences.
Comment 1 Mark Rowe (bdash) 2013-02-20 16:50:56 PST
Created attachment 189415 [details]
Patch v1
Comment 2 Mark Rowe (bdash) 2013-02-20 16:51:33 PST
Created attachment 189417 [details]
Patch v2
Comment 3 WebKit Review Bot 2013-02-20 16:55:35 PST
Attachment 189417 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/PluginService.32.xcconfig', u'Source/WebKit2/Configurations/PluginService.64.xcconfig', u'Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist', u'Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist', u'Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Rowe (bdash) 2013-02-20 17:30:53 PST
Landed in r143543.