Bug 110403

Summary: [BlackBerry] WebPagePrivate::load should not check new window policy
Product: WebKit Reporter: Andrew Lo <anlo>
Component: WebKit BlackBerryAssignee: Andrew Lo <anlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andrew Lo
Reported 2013-02-20 16:11:28 PST
Based on my understanding of http://trac.webkit.org/changeset/135952, we should not check the new window policy in WebPagePrivate::load. None of the other ports seem to do this, except for plugins.
Attachments
Patch (1.55 KB, patch)
2013-02-20 16:17 PST, Andrew Lo
no flags
Patch (1.75 KB, patch)
2013-02-21 10:23 PST, Andrew Lo
no flags
Andrew Lo
Comment 1 2013-02-20 16:17:32 PST
Carlos Garcia Campos
Comment 2 2013-02-21 08:32:50 PST
Comment on attachment 189402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189402&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:744 > FrameLoadRequest frameRequest(m_mainFrame, request); > - frameRequest.setFrameName(""); > - frameRequest.setShouldCheckNewWindowPolicy(true); > m_mainFrame->loader()->load(frameRequest); Now that we don't need the local variable maybe we could leave a single line m_mainFrame->loader()->load(FrameLoadRequest(m_mainFrame, request));
Andrew Lo
Comment 3 2013-02-21 10:23:20 PST
Rob Buis
Comment 4 2013-02-21 10:32:19 PST
Comment on attachment 189552 [details] Patch Looks good.
WebKit Review Bot
Comment 5 2013-02-21 10:55:34 PST
Comment on attachment 189552 [details] Patch Rejecting attachment 189552 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189552, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://queues.webkit.org/results/16699164
WebKit Review Bot
Comment 6 2013-02-21 11:10:54 PST
Comment on attachment 189552 [details] Patch Clearing flags on attachment: 189552 Committed r143629: <http://trac.webkit.org/changeset/143629>
WebKit Review Bot
Comment 7 2013-02-21 11:10:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.