[New Multicolumn] Fix overflow computation for column blocks

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Dave Hyatt]

Fix the overflow computation for column blocks to avoid adding in the RenderFlowThread. Make sure the auto logical height regions code doesn't incorrectly kick in for columns.

[Dave Hyatt]

Created attachment 189390 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 189390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189390&action=review

> Source/WebCore/rendering/RenderRegion.h:143
> +    virtual bool shouldHaveAutoLogicalHeight() const
>      {
>          bool hasSpecifiedEndpointsForHeight = style()->logicalTop().isSpecified() && style()->logicalBottom().isSpecified();
>          bool hasAnchoredEndpointsForHeight = isOutOfFlowPositioned() && hasSpecifiedEndpointsForHeight;
>          return style()->logicalHeight().isAuto() && !hasAnchoredEndpointsForHeight;
>      }

This should not be in the header now that it's virtual.

[Dave Hyatt]

Fixed in r143546.

[Mihai Maerean]

Comment on attachment 189390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189390&action=review

> Source/WebCore/rendering/RenderRegion.h:141
>          bool hasAnchoredEndpointsForHeight = isOutOfFlowPositioned() && hasSpecifiedEndpointsForHeight;

just as a note, the code will run faster if we invert the boolean condition (hasSpecifiedEndpointsForHeight && isOutOfFlowPositioned()) to avoid calling isOutOfFlowPositioned() if hasSpecifiedEndpointsForHeight is false.
this is also true for the next line of code.