Bug 110374 – Accept 'allowfullscreen' in addition to 'webkitallowfullscreen'.

• Component: New Bugs
• Status: RESOLVED FIXED

[Vincent Scheib]

Accept 'allowfullscreen' in addition to 'webkitallowfullscreen'.

[Vincent Scheib]

Created attachment 189365 [details]
Patch

[Adam Barth]

Comment on attachment 189365 [details]
Patch

Should we use FeatureObserver to see how often sites use the prefixed versus the unprefixed attribute?  (We can do that in a followup patch if you like.)

[Vincent Scheib]

Created attachment 189369 [details]
Patch

[WebKit Review Bot]

Attachment 189369 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fullscreen/full-screen-enabled-prefixed-expected.txt', u'LayoutTests/fullscreen/full-screen-enabled-prefixed.html', u'LayoutTests/fullscreen/full-screen-enabled.html', u'LayoutTests/fullscreen/full-screen-iframe-allowed-prefixed-expected.txt', u'LayoutTests/fullscreen/full-screen-iframe-allowed-prefixed.html', u'LayoutTests/fullscreen/full-screen-iframe-allowed.html', u'LayoutTests/fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute-expected.txt', u'LayoutTests/fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html', u'LayoutTests/fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe1.html', u'LayoutTests/fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/html/HTMLAttributeNames.in']" exit_code: 1
LayoutTests/ChangeLog:21:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Vincent Scheib]

Created attachment 189373 [details]
Patch

[Vincent Scheib]

Thanks.

FeatureObserver requires some thought about when and how to measure it -- e.g. per fullscreenRequest, for each nested iframe, for each iframe parsed, etc. I think it should be thought out and done in a separate patch if we want that data.

Also, please re-flag review bit -- I accidentally dropped it on the follow-up patch upload (had omitted one of the new test expectations).

[Vincent Scheib]

Committed r143533: <http://trac.webkit.org/changeset/143533>

[Jer Noble]

*** Bug 110400 has been marked as a duplicate of this bug. ***

[Jer Noble]

Great minds. ;)

[Vincent Scheib]

Ha! ;)

[Eric Seidel (no email)]

Comment on attachment 189373 [details]
Patch

Cleared review? from attachment 189373 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).