Bug 110371

Summary: Cleanup dead MediaSource code after Chromium refactor completes
Product: WebKit Reporter: Aaron Colwell <acolwell>
Component: MediaAssignee: Aaron Colwell <acolwell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, jer.noble, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 109857, 110798    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Rebase none

Description Aaron Colwell 2013-02-20 13:16:00 PST 
This is a follow up bug for cleaning up dead WebKit code, once the MediaSource refactor (https://bugs.webkit.org/show_bug.cgi?id=109857) lands and the Chromium WebMediaPlayerImpl implements its own version of WebMediaPlayer::load(WebURL, WebMediaSource, CORSMode). Once this happens the following code can be removed.

- WebMediaSourceClientImpl in WebMediaPlayerClientImpl.cpp
- WebMediaPlayerClientImpl::sourceOpened()
- WebMediaPlayerClientImpl::sourceURL()
- The default implementation of WebMediaPlayer::load(WebURL, WebMediaSource, CORSMode)
Comment 1 Aaron Colwell 2013-03-08 09:51:59 PST 
Created attachment 192242 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-08 09:54:47 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2013-03-08 09:55:41 PST 
Comment on attachment 192242 [details]
Patch

Attachment 192242 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17016243
Comment 4 WebKit Review Bot 2013-03-08 09:56:30 PST 
Comment on attachment 192242 [details]
Patch

Attachment 192242 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17027281
Comment 5 Peter Beverloo (cr-android ews) 2013-03-08 10:01:33 PST 
Comment on attachment 192242 [details]
Patch

Attachment 192242 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17068503
Comment 6 Aaron Colwell 2013-03-12 19:12:56 PDT 
Created attachment 192856 [details]
Rebase
Comment 7 WebKit Review Bot 2013-03-13 08:40:11 PDT 
Comment on attachment 192856 [details]
Rebase

Clearing flags on attachment: 192856

Committed r145721: <http://trac.webkit.org/changeset/145721>
Comment 8 WebKit Review Bot 2013-03-13 08:40:15 PDT 
All reviewed patches have been landed.  Closing bug.