Bug 110348

Summary: Web Inspector: CSSProperty.status defaults to "style" not "active"
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Severity: Normal CC: apavlov, graouts, joepeck, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch none

Description Timothy Hatcher 2013-02-20 07:30:00 PST
The code and the json file description disagree on what an absent "status" means.

                    { "name": "status", "type": "string", "enum": ["active", "inactive", "disabled", "style"], "optional": true, "description": "The property status: \"active\" (implied if absent) if the property is effective in the style, \"inactive\" if the property is overridden by a same-named property in this style later on, \"disabled\" if the property is disabled by the user, \"style\" if the property is reported by the browser rather than by the CSS source parser." },

        // Default "status" == "style".
        if (status != TypeBuilder::CSS::CSSProperty::Status::Style)

Defaulting to "style" makes more sense to me, and the code agrees.
Comment 1 Alexander Pavlov (apavlov) 2013-02-20 07:34:21 PST
Created attachment 189316 [details]
Comment 2 WebKit Review Bot 2013-02-20 08:10:05 PST
Comment on attachment 189316 [details]

Clearing flags on attachment: 189316

Committed r143465: <http://trac.webkit.org/changeset/143465>
Comment 3 WebKit Review Bot 2013-02-20 08:10:09 PST
All reviewed patches have been landed.  Closing bug.