Bug 110315

Summary: Web Inspector: fix message for non-existent domain warning
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Yury Semikhatsky 2013-02-20 01:54:58 PST 
1. Open inspector for some page and make sure that profiles panel hasn't been shown
2. Navigate inspected page to another URL
3. Open inspector on inspector and look at the console

Result:
Two errors that there were messages for non-existent profiler domains.
Comment 1 Yury Semikhatsky 2013-02-20 01:57:18 PST 
Created attachment 189266 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2013-02-20 01:59:21 PST 
Comment on attachment 189266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189266&action=review

> Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:102
>      // Revisit this.

Is this comment still necessary?
Comment 3 Yury Semikhatsky 2013-02-20 03:52:31 PST 
Created attachment 189281 [details]
Patch
Comment 4 Yury Semikhatsky 2013-02-20 03:52:56 PST 
(In reply to comment #2)
> (From update of attachment 189266 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189266&action=review
> 
> > Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:102
> >      // Revisit this.
> 
> Is this comment still necessary?

No. Removed.
Comment 5 WebKit Review Bot 2013-02-20 04:17:34 PST 
Comment on attachment 189281 [details]
Patch

Clearing flags on attachment: 189281

Committed r143449: <http://trac.webkit.org/changeset/143449>
Comment 6 WebKit Review Bot 2013-02-20 04:17:38 PST 
All reviewed patches have been landed.  Closing bug.