Bug 110311

Summary: [WK2] Remove m_viewportSize in WebPage.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: WebKit2Assignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, andersca, benjamin, cmarcelo, jturcotte, kenneth, menard, noam, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110299    
Bug Blocks: 110066    
Attachments:
Description Flags
Patch none

Dongseong Hwang
Reported 2013-02-19 23:48:24 PST
EFL and Qt use m_viewSize as a contents size while Apple use it as a viewport size, so EFL and Qt introduced m_viewportSize to make WebPage know a viewport size. EFL and Qt use m_viewSize as a contents size because the size of non compositing layer is contents size, and EFL and Qt mark whole non compositing layer as dirty using m_viewSize. Bug 110299 (http://webkit.org/b/110299) changes that it is not necessary to know m_viewSize when marking whole non compositing layer as dirty. So we can make EFL and Qt use m_viewSize as a viewport size also. This patch removes m_viewportSize and related methods to increase readability.
Attachments
Patch (12.59 KB, patch)
2013-02-19 23:52 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2013-02-19 23:52:57 PST
Created attachment 189256 [details] Patch
Anders Carlsson
Comment 2 2013-02-20 09:45:46 PST
Comment on attachment 189256 [details] Patch I'm glad that m_viewSize now means viewport size everywhere, r=me.
WebKit Review Bot
Comment 3 2013-02-20 10:25:25 PST
Comment on attachment 189256 [details] Patch Clearing flags on attachment: 189256 Committed r143474: <http://trac.webkit.org/changeset/143474>
WebKit Review Bot
Comment 4 2013-02-20 10:25:29 PST
All reviewed patches have been landed. Closing bug.
Dongseong Hwang
Comment 5 2013-02-20 17:00:22 PST
(In reply to comment #2) > (From update of attachment 189256 [details]) > I'm glad that m_viewSize now means viewport size everywhere, r=me. Thank you for review. I'm glad too :)
Note You need to log in before you can comment on or make changes to this bug.