Bug 110296

Summary: [New Multicolumn] Make layers paint properly in columns
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, esprehn+autocc, ojan.autocc, WebkitBugTracker, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+, webkit.review.bot: commit-queue-
Patch none

Dave Hyatt
Reported 2013-02-19 21:07:00 PST
Make layers paint properly in columns in both LTR and RTL cases.
Attachments
Patch (15.69 KB, patch)
2013-02-19 21:13 PST, Dave Hyatt 		sam: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (16.41 KB, patch)
2013-02-20 08:32 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2013-02-19 21:13:00 PST
Created attachment 189230 [details] Patch
WebKit Review Bot
Comment 2 2013-02-19 21:16:09 PST
Attachment 189230 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/multicol/newmulticol/layers-in-multicol-expected.html', u'LayoutTests/fast/multicol/newmulticol/layers-in-multicol.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderRegion.cpp']" exit_code: 1 Source/WebCore/rendering/RenderRegion.cpp:45: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] Source/WebCore/rendering/RenderRegion.cpp:46: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2013-02-19 21:51:45 PST
Comment on attachment 189230 [details] Patch Attachment 189230 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16650067 New failing tests: fast/multicol/newmulticol/column-rules-fixed-height.html
Dave Hyatt
Comment 4 2013-02-20 08:32:15 PST
Created attachment 189325 [details] Patch Fix style issue and skip the failing test on chromium.
Dave Hyatt
Comment 5 2013-02-20 09:01:42 PST
Fixed in r143467.
Note You need to log in before you can comment on or make changes to this bug.