| Summary: | [New Multicolumn] Make layers paint properly in columns | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, eric, esprehn+autocc, ojan.autocc, WebkitBugTracker, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Dave Hyatt
2013-02-19 21:07:00 PST
Created attachment 189230 [details]
Patch
Attachment 189230 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/multicol/newmulticol/layers-in-multicol-expected.html', u'LayoutTests/fast/multicol/newmulticol/layers-in-multicol.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderRegion.cpp']" exit_code: 1
Source/WebCore/rendering/RenderRegion.cpp:45: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4]
Source/WebCore/rendering/RenderRegion.cpp:46: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 189230 [details] Patch Attachment 189230 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16650067 New failing tests: fast/multicol/newmulticol/column-rules-fixed-height.html Created attachment 189325 [details]
Patch
Fix style issue and skip the failing test on chromium.
|