Summary: | EME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transition to the new API. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | laszlo.gombos | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jer Noble
2013-02-19 17:14:51 PST
Created attachment 189341 [details]
Patch
I would recommend changing FeatureDefines.h instead (only one change): Index: FeatureDefines.h =================================================================== --- FeatureDefines.h (revision 143483) +++ FeatureDefines.h (working copy) @@ -132,6 +132,12 @@ #endif #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 +#if !defined(ENABLE_ENCRYPTED_MEDIA) +#define ENABLE_ENCRYPTED_MEDIA 1 +#endif +#endif + +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 #if !defined(ENABLE_ENCRYPTED_MEDIA_V2) #define ENABLE_ENCRYPTED_MEDIA_V2 1 #endif If you change FeatureDefines.xcconfig, you need to change all 4 of them together as it is described in the file: // The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore, // WebCore, WebKit and WebKit2. Also the default values of the ENABLE_FEATURE_NAME macros in // build-webkit should match the values below, but they do not need to be in the same order. Committed r143509: <http://trac.webkit.org/changeset/143509> (In reply to comment #2) > I would recommend changing FeatureDefines.h instead .......etc.. Fixed in r143984 . |