Bug 110273

Summary:

webdatabase: Introduce AbstractSQLTransaction and AbstractSQLTransactionBackend

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

WebCore Misc.

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ap, beidson, ggaren, levin+threading, michaeln, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	andersca: review+

Description Mark Lam 2013-02-19 15:56:20 PST

Need to define the transaction interface between the front end and backend.

Comment 1 Mark Lam 2013-02-19 16:01:10 PST

Created attachment 189191 [details]
the patch.

Comment 2 Anders Carlsson 2013-02-19 16:06:32 PST

Comment on attachment 189191 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=189191&action=review

> Source/WebCore/Modules/webdatabase/SQLTransaction.h:79
> +    virtual void requestTransitToState(SQLTransactionState);
> +    virtual bool hasCallback() const;
> +    virtual bool hasSuccessCallback() const;
> +    virtual bool hasErrorCallback() const;
> +    virtual void setBackend(AbstractSQLTransactionBackend*);

You should add OVERRIDE to these.

> Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h:84
> +    virtual void requestTransitToState(SQLTransactionState);
> +    virtual PassRefPtr<SQLError> transactionError();
> +    virtual AbstractSQLStatement* currentStatement();
> +    virtual void setShouldRetryCurrentStatement(bool);
> +    virtual void executeSQL(PassOwnPtr<AbstractSQLStatement>, const String& statement,
> +        const Vector<SQLValue>& arguments, int permissions);

And here.

Comment 3 Mark Lam 2013-02-19 16:51:38 PST

Thanks for there review.  Adjusted patch based on feedback.  Landed in r143412: <http://trac.webkit.org/changeset/143412>.