Bug 110254

Summary: [V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Kentaro Hara 2013-02-19 12:42:15 PST
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951

Currently ScriptRunner::runCompiledScript() calls ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is hitting the ASSERT(). The ASSERT() does not make sense at all. Instead, we should return an empty handle when OOM occurs.
Comment 1 Kentaro Hara 2013-02-19 12:44:08 PST
Created attachment 189145 [details]
Comment 2 WebKit Review Bot 2013-02-19 15:03:02 PST
Comment on attachment 189145 [details]

Clearing flags on attachment: 189145

Committed r143387: <http://trac.webkit.org/changeset/143387>
Comment 3 WebKit Review Bot 2013-02-19 15:03:06 PST
All reviewed patches have been landed.  Closing bug.