Bug 110254

Summary: [V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2013-02-19 12:42:15 PST
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951 Currently ScriptRunner::runCompiledScript() calls ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is hitting the ASSERT(). The ASSERT() does not make sense at all. Instead, we should return an empty handle when OOM occurs.
Attachments
Patch (1.74 KB, patch)
2013-02-19 12:44 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-02-19 12:44:08 PST
Created attachment 189145 [details] Patch
WebKit Review Bot
Comment 2 2013-02-19 15:03:02 PST
Comment on attachment 189145 [details] Patch Clearing flags on attachment: 189145 Committed r143387: <http://trac.webkit.org/changeset/143387>
WebKit Review Bot
Comment 3 2013-02-19 15:03:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.