Bug 110253

Summary: [BlackBerry] Appropriately handle word wrapping in SpellingHandler
Product: WebKit Reporter: Nima Ghanavatian <nghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Nima Ghanavatian 2013-02-19 12:37:42 PST 
ssia
Comment 1 Nima Ghanavatian 2013-02-19 12:56:55 PST 
Created attachment 189147 [details]
Patch
Comment 2 Rob Buis 2013-02-19 13:08:45 PST 
Comment on attachment 189147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189147&action=review

Found some small nits.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:535
> +            endPosition = textRender->visiblePositionForIndex(textLength);

I'd reverse the logic here.

> Source/WebKit/blackberry/WebKitSupport/SpellingHandler.h:35
> +    void setSpellCheckActive(const bool active) { m_isSpellCheckActive = active; }

I am not sure const bool adds anything? It will not make it more efficient AFAICS.
Comment 3 Nima Ghanavatian 2013-02-19 13:16:40 PST 
Created attachment 189150 [details]
Patch
Comment 4 Nima Ghanavatian 2013-02-19 13:27:03 PST 
Created attachment 189152 [details]
Patch
Comment 5 Rob Buis 2013-02-19 13:30:27 PST 
Comment on attachment 189152 [details]
Patch

Looks good.
Comment 6 WebKit Review Bot 2013-02-19 15:17:24 PST 
Comment on attachment 189152 [details]
Patch

Clearing flags on attachment: 189152

Committed r143391: <http://trac.webkit.org/changeset/143391>
Comment 7 WebKit Review Bot 2013-02-19 15:17:27 PST 
All reviewed patches have been landed.  Closing bug.