Bug 110253

Summary: [BlackBerry] Appropriately handle word wrapping in SpellingHandler
Product: WebKit Reporter: Nima Ghanavatian <nghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Nima Ghanavatian
Reported 2013-02-19 12:37:42 PST
ssia
Attachments
Patch (21.94 KB, patch)
2013-02-19 12:56 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (21.85 KB, patch)
2013-02-19 13:16 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (21.84 KB, patch)
2013-02-19 13:27 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2013-02-19 12:56:55 PST
Created attachment 189147 [details] Patch
Rob Buis
Comment 2 2013-02-19 13:08:45 PST
Comment on attachment 189147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189147&action=review Found some small nits. > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:535 > + endPosition = textRender->visiblePositionForIndex(textLength); I'd reverse the logic here. > Source/WebKit/blackberry/WebKitSupport/SpellingHandler.h:35 > + void setSpellCheckActive(const bool active) { m_isSpellCheckActive = active; } I am not sure const bool adds anything? It will not make it more efficient AFAICS.
Nima Ghanavatian
Comment 3 2013-02-19 13:16:40 PST
Created attachment 189150 [details] Patch
Nima Ghanavatian
Comment 4 2013-02-19 13:27:03 PST
Created attachment 189152 [details] Patch
Rob Buis
Comment 5 2013-02-19 13:30:27 PST
Comment on attachment 189152 [details] Patch Looks good.
WebKit Review Bot
Comment 6 2013-02-19 15:17:24 PST
Comment on attachment 189152 [details] Patch Clearing flags on attachment: 189152 Committed r143391: <http://trac.webkit.org/changeset/143391>
WebKit Review Bot
Comment 7 2013-02-19 15:17:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.