Summary: | [BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from element | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yongxin Dai <yodai> | ||||||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dglazkov, mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Yongxin Dai
2013-02-19 10:02:21 PST
Created attachment 189117 [details]
Patch
Attachment 189117 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPageClient.h', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h']" exit_code: 1
Source/WebKit/blackberry/Api/WebPageClient.h:156: The parameter name "handlePosition" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 189124 [details]
Patch
Created attachment 189129 [details]
Patch
Comment on attachment 189129 [details] Patch Attachment 189129 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16614998 New failing tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html Created attachment 189311 [details]
Patch
Comment on attachment 189311 [details]
Patch
based on Mike's review
Comment on attachment 189311 [details] Patch Clearing flags on attachment: 189311 Committed r143461: <http://trac.webkit.org/changeset/143461> All reviewed patches have been landed. Closing bug. |