Bug 110235

Summary: [BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from element
Product: WebKit Reporter: Yongxin Dai <yodai>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Yongxin Dai
Reported 2013-02-19 10:02:21 PST
data-blackberry-text-selection-handle-position specifies the position of selection handles.
Attachments
Patch (5.98 KB, patch)
2013-02-19 11:07 PST, Yongxin Dai 		no flags
DetailsFormatted DiffDiff
Patch (5.98 KB, patch)
2013-02-19 11:38 PST, Yongxin Dai 		no flags
DetailsFormatted DiffDiff
Patch (5.96 KB, patch)
2013-02-19 11:55 PST, Yongxin Dai 		no flags
DetailsFormatted DiffDiff
Patch (8.35 KB, patch)
2013-02-20 06:53 PST, Yongxin Dai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yongxin Dai
Comment 1 2013-02-19 11:07:09 PST
Created attachment 189117 [details] Patch
WebKit Review Bot
Comment 2 2013-02-19 11:11:22 PST
Attachment 189117 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPageClient.h', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h']" exit_code: 1 Source/WebKit/blackberry/Api/WebPageClient.h:156: The parameter name "handlePosition" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yongxin Dai
Comment 3 2013-02-19 11:38:56 PST
Created attachment 189124 [details] Patch
Yongxin Dai
Comment 4 2013-02-19 11:55:35 PST
Created attachment 189129 [details] Patch
WebKit Review Bot
Comment 5 2013-02-19 13:08:15 PST
Comment on attachment 189129 [details] Patch Attachment 189129 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16614998 New failing tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html
Yongxin Dai
Comment 6 2013-02-20 06:53:04 PST
Created attachment 189311 [details] Patch
Yong Li
Comment 7 2013-02-20 07:12:07 PST
Comment on attachment 189311 [details] Patch based on Mike's review
WebKit Review Bot
Comment 8 2013-02-20 07:26:08 PST
Comment on attachment 189311 [details] Patch Clearing flags on attachment: 189311 Committed r143461: <http://trac.webkit.org/changeset/143461>
WebKit Review Bot
Comment 9 2013-02-20 07:26:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.