Bug 110217

Summary:

[chromium] move most of the remaining mocks to TestRunner library

Product:

WebKit

Reporter:

jochen

Component:

New Bugs

Assignee:

jochen

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	none

jochen

Reported 2013-02-19 06:49:56 PST

[chromium] move most of the remaining mocks to TestRunner library

Attachments
Patch (89.90 KB, patch) 2013-02-19 06:50 PST, jochen	no flags	Details Formatted Diff Diff
Patch (98.00 KB, patch) 2013-02-20 05:22 PST, jochen	no flags	Details Formatted Diff Diff
Patch (97.99 KB, patch) 2013-02-20 05:36 PST, jochen	no flags	Details Formatted Diff Diff
Patch for landing (97.98 KB, patch) 2013-02-20 05:37 PST, jochen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

jochen

Comment 1 2013-02-19 06:50:52 PST

Created attachment 189080 [details] Patch

WebKit Review Bot

Comment 2 2013-02-19 06:54:45 PST

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

WebKit Review Bot

Comment 3 2013-02-19 08:29:56 PST

Comment on attachment 189080 [details] Patch Attachment 189080 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16628581 New failing tests: fast/dom/Geolocation/position-string.html fast/dom/Geolocation/cached-position-iframe.html inspector/geolocation-error.html

jochen

Comment 4 2013-02-19 09:06:25 PST

I guess I'll need to move the mocks to WebTestProxyBase instead of TestRunner. Anyway, the public/ API changes will stay the same, can I already get a lgtm for that?

Adam Barth

Comment 5 2013-02-19 12:12:21 PST

Comment on attachment 189080 [details] Patch API changes LGTM

jochen

Comment 6 2013-02-20 05:22:21 PST

Created attachment 189289 [details] Patch

WebKit Review Bot

Comment 7 2013-02-20 05:34:53 PST

Attachment 189289 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/DumpRenderTree.gypi', u'Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp', u'Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h', u'Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp', u'Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h', u'Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp', u'Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h', u'Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp', u'Tools/DumpRenderTree/chromium/WebViewHost.cpp', u'Tools/DumpRenderTree/chromium/WebViewHost.h']" exit_code: 1 Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:65: The parameter name "proxy" adds no information, so it should be removed. [readability/parameter_name] [5] Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:66: The parameter name "proxy" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Nico Weber

Comment 8 2013-02-20 05:36:24 PST

Comment on attachment 189289 [details] Patch Makes sense. I didn't look super closely since this is just moving existing code around.

jochen

Comment 9 2013-02-20 05:36:37 PST

Created attachment 189295 [details] Patch

jochen

Comment 10 2013-02-20 05:37:24 PST

Created attachment 189297 [details] Patch for landing

WebKit Review Bot

Comment 11 2013-02-20 06:11:49 PST

Comment on attachment 189297 [details] Patch for landing Clearing flags on attachment: 189297 Committed r143457: <http://trac.webkit.org/changeset/143457>

WebKit Review Bot

Comment 12 2013-02-20 06:11:53 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.