Bug 110180

Summary: Refactoring FixedTableLayout class for readability.
Product: WebKit Reporter: Pravin D <pravind>
Component: TablesAssignee: Pravin D <pravind>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ahmad.saleem792, eric, jchaffraix, ojan.autocc, webkit.review.bot, zalan
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Pravin D
Reported 2013-02-18 22:46:40 PST
Refactoring the code width distribution code in FixedTableLayout::layout() for readability.
Attachments
Patch (4.01 KB, text/plain)
2013-02-19 08:25 PST, Pravin D 		no flags
Details
Patch (4.34 KB, patch)
2013-02-19 08:42 PST, Pravin D 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pravin D
Comment 1 2013-02-19 08:25:46 PST
Created attachment 189093 [details] Patch
Pravin D
Comment 2 2013-02-19 08:42:10 PST
Created attachment 189096 [details] Patch
Julien Chaffraix
Comment 3 2013-02-19 11:15:25 PST
Comment on attachment 189096 [details] Patch Really not sure how much more clear this is but it's moot from my perspective. As discussed on IRC, I would rather have the algorithm straightened up (like how we shrink looks suspicious (I would argue that shrinking is probably a wrong idea but that could be needed for compatibility)), maybe the different parts split up, unify the extra logical width spreading... This would lead to a much more readable code.
Andreas Kling
Comment 4 2014-02-05 11:11:07 PST
Comment on attachment 189096 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Ahmad Saleem
Comment 5 2023-04-02 08:03:20 PDT
@Alan - do we need to track it up, we can apply this patch (I looked into it) but I think Julien mentioned that it is not fixing much or anything. I just trying to close old bugs so if we don't need to do anything, we can close this or if you want me to apply patch, I can try it with local build. https://searchfox.org/wubkat/source/Source/WebCore/rendering/FixedTableLayout.cpp#266
alan
Comment 6 2023-04-02 20:51:35 PDT
(In reply to Ahmad Saleem from comment #5) > @Alan - do we need to track it up, we can apply this patch (I looked into > it) but I think Julien mentioned that it is not fixing much or anything. > > I just trying to close old bugs so if we don't need to do anything, we can > close this or if you want me to apply patch, I can try it with local build. > > https://searchfox.org/wubkat/source/Source/WebCore/rendering/ > FixedTableLayout.cpp#266 I wouldn't put too much effort into it.
Ahmad Saleem
Comment 7 2023-04-02 20:58:32 PDT
Closing this old bug now based on discussion with Alan. :-)
Note You need to log in before you can comment on or make changes to this bug.