Bug 110165

Summary: Merge handleSpecialChild into layoutBlockChildren
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn, hyatt, jchaffraix, ojan.autocc, robert, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup darin: review+

Ryosuke Niwa
Reported 2013-02-18 16:24:32 PST
The name handleSpecialChild is extremely vague and doesn't communicate at all what it's handling and what "special" children are. Since this function is only called by layoutBlockChildren, we can merge into layoutBlockChildren altogether. In fact, handlePositionedChild and handleFloatingChild can also be merged into layoutBlockChildren. That allows us to remove outdated comment in layoutBlockChildren that says: // Handle the four types of special elements first. These include positioned content, floating content, compacts and // run-ins. When we encounter these four types of objects, we don't actually lay them out as normal flow blocks. which at this point is only half true.
Attachments
Cleanup (3.93 KB, patch)
2013-02-18 16:28 PST, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-02-18 16:28:47 PST
Created attachment 188960 [details] Cleanup
Ryosuke Niwa
Comment 2 2013-02-18 19:44:10 PST
Committed r143290: <http://trac.webkit.org/changeset/143290>
Eric Seidel (no email)
Comment 3 2013-02-20 10:28:31 PST
Thanks.
Note You need to log in before you can comment on or make changes to this bug.