Bug 110152

Summary: Make HexNumber functions return 8-bit strings
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Web Template FrameworkAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, dglazkov, msaboff, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch msaboff: review+, webkit.review.bot: commit-queue-

Alexey Proskuryakov
Reported 2013-02-18 13:30:59 PST
I'm seeing them unnecessarily make URLs 16-bit, blob ones in particular.
Attachments
proposed patch (3.53 KB, patch)
2013-02-18 13:36 PST, Alexey Proskuryakov 		msaboff: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-02-18 13:36:59 PST
Created attachment 188938 [details] proposed patch
Michael Saboff
Comment 2 2013-02-18 13:55:16 PST
Comment on attachment 188938 [details] proposed patch r+ I have a slight concern on platforms where char is signed that the compiler may complain for the cases we are adding an LChar to a char buffer. An example is the call to placeByteAsHex in appendEscapedChar in KURL.cpp
WebKit Review Bot
Comment 3 2013-02-18 14:18:38 PST
Comment on attachment 188938 [details] proposed patch Attachment 188938 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16613339 New failing tests: fast/regions/seamless-iframe-flowed-into-regions.html
Alexey Proskuryakov
Comment 4 2013-02-18 14:40:38 PST
Committed <http://trac.webkit.org/r143265>. The failure looks unrelated.
Note You need to log in before you can comment on or make changes to this bug.