Summary: | Make HexNumber functions return 8-bit strings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | Web Template Framework | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, cmarcelo, dglazkov, msaboff, ojan.autocc, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2013-02-18 13:30:59 PST
Created attachment 188938 [details]
proposed patch
Comment on attachment 188938 [details]
proposed patch
r+
I have a slight concern on platforms where char is signed that the compiler may complain for the cases we are adding an LChar to a char buffer. An example is the call to placeByteAsHex in appendEscapedChar in KURL.cpp
Comment on attachment 188938 [details] proposed patch Attachment 188938 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16613339 New failing tests: fast/regions/seamless-iframe-flowed-into-regions.html Committed <http://trac.webkit.org/r143265>. The failure looks unrelated. |