Bug 110124

Summary: Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Ilya Tikhonovsky
Reported 2013-02-18 08:43:13 PST
Some nodes have nonzero name property that was assigned via MemoryObjectInfo::setName method This name may give the user a clue which particular object takes so much memory. As example in case of WebCore::CachedImage the instrumentation provides url as the name of the object.
Attachments
Patch (5.17 KB, patch)
2013-02-18 08:45 PST, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2013-02-18 08:45:37 PST
Created attachment 188895 [details] Patch
Yury Semikhatsky
Comment 2 2013-02-19 04:12:05 PST
Comment on attachment 188895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188895&action=review > Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:186 > + this._worker = /*typeof InspectorTest === "undefined" ? new WebInspector.HeapSnapshotRealWorker() :*/ new WebInspector.HeapSnapshotFakeWorker(); Please revert this. > Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:112 > + userProvidedName: this.name(), displayName ?
Ilya Tikhonovsky
Comment 3 2013-02-19 04:23:09 PST
Committed r143317: <http://trac.webkit.org/changeset/143317>
Note You need to log in before you can comment on or make changes to this bug.