Bug 110061

Summary: AX: rename WebAccessibilityObjectWrapper to WebAccessibilityObjectWrapperBase
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch ddkilzer: review+, ddkilzer: commit-queue-

chris fleizach
Reported 2013-02-17 13:16:06 PST
Then that way WebAccessibilityObjectWrapperMac and WebAccessibilityObjectWrapperIOS can just be WebAccessibilityObjectWrapper and things will be a bit cleaner
Attachments
patch (200.28 KB, patch)
2013-02-17 13:33 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (200.99 KB, patch)
2013-02-17 13:49 PST, chris fleizach 		ddkilzer: review+
ddkilzer: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2013-02-17 13:33:04 PST
Created attachment 188773 [details] patch
chris fleizach
Comment 2 2013-02-17 13:34:21 PST
Xcode keeps trying to reorder these other changes in the Xcode project, so maybe i shouldn't fight them anymore
chris fleizach
Comment 3 2013-02-17 13:49:27 PST
Created attachment 188775 [details] patch
David Kilzer (:ddkilzer)
Comment 4 2013-02-17 18:35:40 PST
Comment on attachment 188775 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=188775&action=review r=me as long as you don't rename WebAccessibilityObjectWrapperMac.{h|mm} to remove "Mac" from the name. > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm:30 > -#import "WebAccessibilityObjectWrapperMac.h" > +#import "WebAccessibilityObjectWrapper.h" Please leave these files named as WebAccessibilityObjectWrapperMac.{h|mm} even though the class is named "WebAccessibilityObjectWrapper" so that it's easier to know which implementation is being included or compiled.
David Kilzer (:ddkilzer)
Comment 5 2013-02-17 18:36:39 PST
(In reply to comment #2) > Xcode keeps trying to reorder these other changes in the Xcode project, so maybe i shouldn't fight them anymore Yes, whoever changed these files didn't use Xcode to change them since the UUID sort order is borked. It's fine to let Xcode have its way with the project file.
chris fleizach
Comment 6 2013-02-17 19:37:16 PST
http://trac.webkit.org/changeset/143142
Note You need to log in before you can comment on or make changes to this bug.