Bug 110057

Summary: [GTK][AC] Implement keyframe animations with clutter ac backend
Product: WebKit Reporter: ChangSeok Oh <kevin.cs.oh>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gns, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 105699    
Attachments:
Description Flags
Patch
none
Patch none

Description ChangSeok Oh 2013-02-17 10:58:30 PST 
This bug is for bringing accelearted animation with clutter to webkitgtk port.
Comment 1 ChangSeok Oh 2013-02-17 11:19:08 PST 
Created attachment 188770 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-02-19 06:37:18 PST 
Comment on attachment 188770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188770&action=review

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:775
> +            // If any matrix is singular, CA won't animate it correctly. So fall back to software animation

CA reference.
Comment 3 Gustavo Noronha (kov) 2013-02-19 06:37:37 PST 
Comment on attachment 188770 [details]
Patch

Err, actually, there was a nit, so cq-
Comment 4 ChangSeok Oh 2013-02-19 07:42:52 PST 
Created attachment 189089 [details]
Patch
Comment 5 ChangSeok Oh 2013-02-19 07:45:33 PST 
Comment on attachment 188770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188770&action=review

Thank you for the review :)

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:775
>> +            // If any matrix is singular, CA won't animate it correctly. So fall back to software animation
> 
> CA reference.

Updated this comment.
Comment 6 WebKit Review Bot 2013-02-19 09:03:14 PST 
Comment on attachment 189089 [details]
Patch

Clearing flags on attachment: 189089

Committed r143343: <http://trac.webkit.org/changeset/143343>
Comment 7 WebKit Review Bot 2013-02-19 09:03:18 PST 
All reviewed patches have been landed.  Closing bug.